fix(shared-data): Fix the pipette schemas, tests #13949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
requested review from
ahiuchingau,
Laura-Danielle and
caila-marashaj
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13949 +/- ##
==========================================
- Coverage 70.79% 70.76% -0.04%
==========================================
Files 2505 2478 -27
Lines 70620 69876 -744
Branches 8663 8501 -162
==========================================
- Hits 49997 49447 -550
+ Misses 18501 18332 -169
+ Partials 2122 2097 -25
Flags with carried forward coverage won't be shown. Click here to find out more. |
The tests that were supposed to ajv the pipette definitions weren't set up properly, and the tests that were supposed to test that the tests were set up properly weren't set up properly, so we weren't testing the schemas so the schemas were wrong. Fix the schema-test setup, the test-setup-schema-test setup, and the schema.
sfoster1
force-pushed
the
fix-pipette-schemas
branch
from
83635d1
to
f2ca4d0
Compare
Laura-Danielle
approved these changes
Nov 9, 2023
| @@ -18,6 +18,7 @@ def test_check_all_models_are_valid() -> None: | |||
| "ninety_six_channel": "96", | |||
| "eight_channel": "multi", | |||
| } | |||
| assert os.listdir(paths_to_validate), "You have a path wrong" | |||
There was a problem hiding this comment.
IMO yes, we do it in the js tests too
ncdiehl11
pushed a commit
that referenced
this pull request
Nov 14, 2023
The tests that were supposed to ajv the pipette definitions weren't set up properly, and the tests that were supposed to test that the tests were set up properly weren't set up properly, so we weren't testing the schemas so the schemas were wrong. Fix the schema-test setup, the test-setup-schema-test setup, and the schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests that were supposed to ajv the pipette definitions weren't set up properly, and the tests that were supposed to test that the tests were set up properly weren't set up properly, so we weren't testing the schemas so the schemas were wrong. Fix the schema-test setup, the test-setup-schema-test setup, and the schema.